Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace pushd/popd Calls With -S/-B CMake Flags in the Build System #94353

Merged
merged 7 commits into from
Nov 29, 2023
Merged

Replace pushd/popd Calls With -S/-B CMake Flags in the Build System #94353

merged 7 commits into from
Nov 29, 2023

Conversation

ivdiazsa
Copy link
Member

@ivdiazsa ivdiazsa commented Nov 3, 2023

Completes #93702. With our build system requiring at least CMake version 3.20, we can now use its -S and -B flags to choose source and build paths, rather than changing directories with pushd and popd. This PR adds this enhancement to the build system.

@ghost ghost assigned ivdiazsa Nov 3, 2023
@ghost
Copy link

ghost commented Nov 3, 2023

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Completes #93702. With our build system requiring at least CMake version 3.20, we can now use its -S and -B flags to choose source and build paths, rather than changing directories with pushd and popd. This PR adds this enhancement to the build system.

Author: ivdiazsa
Assignees: -
Labels:

area-Infrastructure-libraries
Milestone: -

@ghost
Copy link

ghost commented Nov 3, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

Completes #93702. With our build system requiring at least CMake version 3.20, we can now use its -S and -B flags to choose source and build paths, rather than changing directories with pushd and popd. This PR adds this enhancement to the build system.

Author: ivdiazsa
Assignees: ivdiazsa
Labels:

area-Infrastructure-coreclr
Milestone: -

@ivdiazsa ivdiazsa added this to the 9.0.0 milestone Nov 3, 2023
@ivdiazsa ivdiazsa linked an issue Nov 3, 2023 that may be closed by this pull request
Use the -S and -B Options on the CMake Command Line to Specify Source and Build Directories Instead of Moving with pushd #93702
Closed
@ivdiazsa
Copy link
Member Author

ivdiazsa commented Nov 3, 2023

Well it broke everything as I kind of expected. Now, currently investigating the issue 😄

This was referenced Nov 3, 2023
Closed
Closed
Open
Closed
@ivdiazsa ivdiazsa marked this pull request as ready for review November 6, 2023 19:58
@ivdiazsa
Copy link
Member Author

ivdiazsa commented Nov 6, 2023

Failure is unrelated, so this PR is now ready for review.

@ivdiazsa
Copy link
Member Author

/azp run runtime

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@ivdiazsa
Copy link
Member Author

Running the normal runtime pipeline to ensure this still works, since it's been a long while since it was tested.

@am11 am11 mentioned this pull request Nov 29, 2023
Closed
@akoeplinger
Add explicit exit code to gen-buildsys.sh
360a3db 
Make sure we don't forget to return the cmake exist code, see #95408.
@ivdiazsa
Copy link
Member Author

Failures are unrelated to this change. Merging now.

@ivdiazsa ivdiazsa merged commit 9bb2b5b into dotnet:main Nov 29, 2023
186 of 191 checks passed
This was referenced Nov 29, 2023
Closed
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

Assignees

@ivdiazsa ivdiazsa

Labels
area-Infrastructure-coreclr
Projects
Infrastructure Backlog
Status: Closed
Milestone
9.0.0
3 participants
@ivdiazsa @akoeplinger @jkoritzinsky